[sv-ec] RE: [sv-champions] email vote concurrently run for both sv-ec and the champions, ending May 27th

I have two comments on Mantis 2575 for which I would like to hear feedback.


Comment #1. The proposal makes the following BNF change:

FROM
 
constant_primary ::=
...
| ps_parameter_identifier constant_select

TO

constant_primary ::=
...
| [package_scope | class_scope] parameter_identifier constant_select

That is, "ps_parameter_identifier" is replaced with "[package_scope | class_scope]".

I see two problems with this:

A. 

ps_parameter_identifier ::=
  [ package_scope ] parameter_identifier
| { generate_block_identifier [ [ constant_expression ] ] . } parameter_identifier

Making the change in constant_primary will remove the second alternative of ps_parameter_identifier (a generate block parameter) from constant_primary.

B. ps_parameter_identifier appears in two other places in the BNF:

simple_type ::= integer_type | non_integer_type | ps_type_identifier | ps_parameter_identifier

assignment_pattern_expression_type ::=
  ps_type_identifier
| ps_parameter_identifier
| integer_atom_type
| type_reference

Does it not make sense to make this change (to add class_scope) in those places as well?

It seems to me more logical to make the change in ps_parameter_identifier:

ps_parameter_identifier ::=
  [ package_scope | class_scope ] parameter_identifier
| { generate_block_identifier [ [ constant_expression ] ] . } parameter_identifier


Comment #2:

Can parameters be overridden in derived classes? (8.13)


Editorial corrections:

8.14: "An expression using super to access the value parameter or local value parameter is not a constant expression."

"super" should be bold.


8.22: "In addition to disambiguating class scope identifiers, the :: operator also allows access to static members (class properties and methods , class parameters, and class local parameters from outside the class, as well as access to public or protected elements of a superclass from within the derived classes."

There should be a closing right parenthesis after "class local parameters".


8.22: "A class parameter, or local parameter is a public element of a class."

There should be no comma in the sentence.


Shalom
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.