[sv-ec] Mantis 2506 - cross BNF error ?

Hi,

I think I have found an error in the new BNF for cross coverage specification in Mantis 2506.

The current BNF says this:

cover_cross ::= [ cross_identifier : ] cross list_of_coverpoints [ iff ( expression ) ] select_bins_or_empty

select_bins_or_empty ::=
{ { bins_selection_or_option ; } }
| ;

The body of the cross specification, after the list of coverpoints, is either null or a bracket-enclosed set of one or more bin specifications.

The new BNF proposed by 2506 says:

cover_cross ::=
    [ cross_identifier : ] cross list_of_cross_items [ iff ( expression ) ] cross_body

cross_body ::=
    { { bins_selection_or_option ; } }
  | function_declaration
  | ;

Now the body of the cross specification, after the list of coverpoints, is either null or a single function declaration or a bracket-enclosed set of one or more bin specifications.

I don't think this was the intention.

I think the intention was for the cross body to be a bracket-enclosed set of one or more bin specifications and function declarations.

The following example from 19.6.1.4 does not appear to be legal under this BNF:

        aXb : cross a, b
        {
          function CrossQueueType myFunc1(int f_lim);
           for (int i = 0; i < f_lim; ++i)
             myFunc1.push_back(CrossValType'('{i,i}));
          endfunction

          bins one = myFunc1(cg_lim);
          bins two = myFunc2(cg_lim);

          function CrossQueueType myFunc2(logic [31:0] f_lim);
            for (logic [31:0] i = 0; i < f_lim; ++i)
              myFunc2.push_back('{2*i,2*i});
          endfunction
        }

I think the BNF should be something like this:

cross_body ::=
    { { cross_body_item } }
  | ;

cross_body_item ::=
          function_declaration
        | bins_selection_or_option ;

If I am correct, then I think that SV-EC and the Champions should request the Working Group to allow SV-EC to fix the proposal. (Some of the other, more editorial, problems, could also be fixed at the same time.)

Thanks,
Shalom

Shalom Bresticker
Intel LAD DA, Jerusalem, Israel
+972 2 589 6582 (office)
+972 54 721 1033 (cell)
http://www.linkedin.com/in/shalombresticker

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.